Skip to content

Conversation

ranger-ross
Copy link
Contributor

@ranger-ross ranger-ross commented May 25, 2025

This PR adds doc comments for unstables features in compiler/rustc_feature/src/unstable.rs to the unstable book feature pages.

Fixes #141528

Example features rendered

image

image

r? @jyn514

@rustbot

This comment was marked as resolved.

@rustbot
Copy link
Collaborator

rustbot commented May 25, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 25, 2025
@Urgau
Copy link
Member

Urgau commented May 25, 2025

r? Urgau @rustbot author

@rustbot rustbot assigned Urgau and unassigned Kobzol May 25, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 25, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@ranger-ross ranger-ross force-pushed the unstable-feature-doc-comments branch from 4169af7 to 3850b1f Compare May 25, 2025 11:00
@ranger-ross
Copy link
Contributor Author

Thanks for the quick review. Addressed your feedback.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 25, 2025
@Urgau Urgau added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 25, 2025
@Urgau
Copy link
Member

Urgau commented May 25, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 25, 2025

📌 Commit 3850b1f has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025
bors added a commit that referenced this pull request May 25, 2025
Rollup of 6 pull requests

Successful merges:

 - #141413 (Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING)
 - #141443 (make teach_help message for cast-before-pass-to-variadic more precise)
 - #141508 (bootstrap: clippy: set TESTNAME based on given paths)
 - #141512 (Avoid extra path trimming in method not found error)
 - #141530 (Added unstable feature doc comments to unstable book)
 - #141541 (Random nits)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5cc2733 into rust-lang:master May 25, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 25, 2025
rust-timer added a commit that referenced this pull request May 25, 2025
Rollup merge of #141530 - ranger-ross:unstable-feature-doc-comments, r=Urgau

Added unstable feature doc comments to unstable book

This PR adds doc comments for unstables features in [compiler/rustc_feature/src/unstable.rs](https://github.com/rust-lang/rust/blob/d3a2440384b54664dddd56e0081ca094c444e869/compiler/rustc_feature/src/unstable.rs#L190-L191) to the unstable book feature pages.

Fixes #141528

Example features rendered

![image](https://github.com/user-attachments/assets/2b65f534-26f8-441f-ba29-65554c9154b7)

![image](https://github.com/user-attachments/assets/6077491b-ddaf-447e-9519-0bc110c7a893)

r? `@jyn514`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc-comments on unstable features should end up in the unstable book
5 participants